linux-kernel - Re: [PATCH RESEND 0/2] RISC-V: Handle the siginfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mvmpnmqfepx.fsf@suse.de>
Date:   Thu, 04 Jul 2019 09:20:26 +0200
From:   Andreas Schwab <schwab@...e.de>
To:     Alistair Francis <alistair23@...il.com>
Cc:     Alistair Francis <alistair.francis@....com>,
        linux-riscv@...ts.infradead.org, Arnd Bergmann <arnd@...db.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND 0/2] RISC-V: Handle the siginfo_t offset problem

On Jul 03 2019, Alistair Francis <alistair23@...il.com> wrote:

> On Wed, Jul 3, 2019 at 12:08 AM Andreas Schwab <schwab@...e.de> wrote:
>>
>> On Jul 02 2019, Alistair Francis <alistair.francis@....com> wrote:
>>
>> > In the RISC-V 32-bit glibc port [1] the siginfo_t struct in the kernel
>> > doesn't line up with the struct in glibc. In glibc world the _sifields
>> > union is 8 byte alligned (although I can't figure out why)
>>
>> Try ptype/o in gdb.
>
> That's a useful tip, I'll be sure to use that next time.

It was a serious note.  If the structs don't line up then there is a
mismatch in types that cannot be solved by adding spurious padding.  You
need to fix the types instead.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@...e.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."