linux-kernel - Re: [PATCH] ARM: Kconfig: default to AEABI w/ Clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2uW+a_=siusLTt=rq-erw1tyJfU8PDGaXuVcJoKHjpRw@mail.gmail.com>
Date:   Thu, 4 Jul 2019 09:24:24 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     Russell King - ARM Linux <linux@...linux.org.uk>,
        clang-built-linux <clang-built-linux@...glegroups.com>,
        Mark Brown <broonie@...nel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Paul Burton <paul.burton@...s.com>,
        Mike Rapoport <rppt@...ux.ibm.com>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Palmer Dabbelt <palmer@...ive.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: Kconfig: default to AEABI w/ Clang

On Tue, Jun 25, 2019 at 11:04 PM 'Nick Desaulniers' via Clang Built
Linux <clang-built-linux@...glegroups.com> wrote:
>
> Clang produces references to __aeabi_uidivmod and __aeabi_idivmod for
> arm-linux-gnueabi and arm-linux-gnueabihf targets incorrectly when AEABI
> is not selected (such as when OABI_COMPAT is selected).
>
> While this means that OABI userspaces wont be able to upgraded to
> kernels built with Clang, it means that boards that don't enable AEABI
> like s3c2410_defconfig will stop failing to link in KernelCI when built
> with Clang.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/482
> Link: https://groups.google.com/forum/#!msg/clang-built-linux/yydsAAux5hk/GxjqJSW-AQAJ
> Suggested-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com>

Looks good to me,

Reviewed-by: Arnd Bergmann <arnd@...db.de>

Please add it to Russell's patch tracker if you haven't already.

Most of the .config files that don't set AEABI (and a lot of the others
as well) have likely never been booted on real hardware with a modern
kernel in a long time. There have not been any distros using OABI in
a long time (Debian Lenny was released in 2009), and gcc dropped
support for it a few years later.

We could probably change most of these to use OABI_COMPAT
instead, aside from any ones that Russell wants to keep building as
OABI for his own machines.

       Arnd