linux-kernel - [PATCH] scsi: fdomain: Fix PCMCIA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 4 Jul 2019 16:01:56 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>,
        <gregkh@...uxfoundation.org>, <linux@...y.sk>
CC:     <linux-kernel@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
        YueHaibing <yuehaibing@...wei.com>
Subject: [PATCH] scsi: fdomain: Fix PCMCIA_FDOMAIN Kconfig warning

Fix Kconfig warning for PCMCIA_FDOMAIN symbol:

WARNING: unmet direct dependencies detected for SCSI_FDOMAIN
  Depends on [n]: SCSI_LOWLEVEL [=n] && SCSI [=y]
  Selected by [m]:
  - PCMCIA_FDOMAIN [=m] && SCSI_LOWLEVEL_PCMCIA [=y] && SCSI [=y] && PCMCIA [=m] && m && MODULES [=y]

Add SCSI_FDOMAIN and SCSI_LOWLEVEL dependency.

Reported-by: Hulk Robot <hulkci@...wei.com>
Fixes: 8674a8aa2c39 ("scsi: fdomain: Add PCMCIA support")
Signed-off-by: YueHaibing <yuehaibing@...wei.com>
---
 drivers/scsi/pcmcia/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/pcmcia/Kconfig b/drivers/scsi/pcmcia/Kconfig
index 2368f34..f23a572 100644
--- a/drivers/scsi/pcmcia/Kconfig
+++ b/drivers/scsi/pcmcia/Kconfig
@@ -22,7 +22,7 @@ config PCMCIA_AHA152X
 
 config PCMCIA_FDOMAIN
 	tristate "Future Domain PCMCIA support"
-	select SCSI_FDOMAIN
+	depends on SCSI_FDOMAIN && SCSI_LOWLEVEL
 	help
 	  Say Y here if you intend to attach this type of PCMCIA SCSI host
 	  adapter to your computer.
-- 
2.7.4