linux-kernel - RE: linux-next: build failure after merge of the usb and usb-gadget trees

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR07MB470946609232100714B3EA29DDFA0@BYAPR07MB4709.namprd07.prod.outlook.com>
Date:   Thu, 4 Jul 2019 08:07:06 +0000
From:   Pawel Laszczak <pawell@...ence.com>
To:     Felipe Balbi <balbi@...nel.org>, Greg KH <greg@...ah.com>
CC:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: RE: linux-next: build failure after merge of the usb and usb-gadget
 trees

>
>Hi,
>
>On Thu, Jul 4, 2019 at 9:59 AM Greg KH <greg@...ah.com> wrote:
>>
>> On Thu, Jul 04, 2019 at 04:34:58PM +1000, Stephen Rothwell wrote:
>> > Hi all,
>> >
>> > After merging the usb tree, today's linux-next build (arm
>> > multi_v7_defconfig) failed like this:
>> >
>> > arm-linux-gnueabi-ld: drivers/usb/dwc3/trace.o: in function `trace_raw_output_dwc3_log_ctrl':
>> > trace.c:(.text+0x119c): undefined reference to `usb_decode_ctrl'
>> >
>> > Caused by commit
>> >
>> >   3db1b636c07e ("usb:gadget Separated decoding functions from dwc3 driver.")
>> >
>> > I have used the usb tree from next-20190703 for today.
>> >
>> > This also occurs in the usb-gadget tree so I have used the version of
>> > that from next-20190703 as well.
>>
>> Odd, I thought I pulled the usb-gadget tree into mine.  Felipe, can you
>> take a look at this to see if I messed something up?
>
>This looks like it was caused by Pawel's patches.
>
>I'll try to reproduce here and see what's causing it.

Problem is in my Patch. I reproduced it, but I don't understand why compiler 
complains about usb_decode_ctrl. It's compiled into libcomposite.ko and
declaration is in drivers/usb/gadget.h. 

>
>--
>balbi