linux-kernel - RE: Re: Re: [PATCH V2 2/2] PCI: Add NI-Serial PXI/PXIe+485 device IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MN2PR04MB5920DFD232850F4F2CB28C47B7FA0@MN2PR04MB5920.namprd04.prod.outlook.com>
Date:   Thu, 4 Jul 2019 08:17:38 +0000
From:   Je Yen Tam <je.yen.tam@...com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: Re: Re: [PATCH V2 2/2] PCI: Add NI-Serial PXI/PXIe+485 device IDs

> -----Original Message-----
> From: Greg KH <gregkh@...uxfoundation.org>
> Sent: Thursday, July 4, 2019 4:16 PM
> To: Je Yen Tam <je.yen.tam@...com>
> Cc: linux-serial@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [EXTERNAL] Re: Re: [PATCH V2 2/2] PCI: Add NI-Serial PXI/PXIe+485 device
> IDs
> 
> On Thu, Jul 04, 2019 at 06:58:39AM +0000, Je Yen Tam wrote:
> > > On Wed, Jul 03, 2019 at 12:25:16AM -0700, jeyentam wrote:
> > > > Add NI PXIe-RS232, PXI-RS485 and PXIe-RS485 device IDs.
> > > >
> > > > Signed-off-by: jeyentam <je.yen.tam@...com>
> > > > ---
> > > >  include/linux/pci_ids.h | 12 ++++++++++++
> > > >  1 file changed, 12 insertions(+)
> > >
> > > You have read the comment at the top of this file, right?  If so, why
> > > are you adding these entries?
> >
> > Yes, but I think these entries should be added in because the NI-Serial PXI
> > (RS232) device IDs already been defined in this file originally, so now I'm
> > adding the newly supported NI-Serial PXI (RS485), PXIe (RS232) and PXIe
> > (RS485) device IDs into here as they are the same product.
> 
> No, do not add new device ids to this file, only put them in the single
> file that needs it.  This file is for device ids that are shared across
> multiple drivers/files.
> 
> You should not need to touch this file at all.

Ok, understood. Will do so.

> 
> thanks,
> 
> greg k-h

Thank you,
Je Yen