linux-kernel - Re: [PATCH RESEND v3] staging: erofs: remove unsupported ->datamode check in fill_inline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190704180207.0000374e.zbestahu@gmail.com>
Date:   Thu, 4 Jul 2019 18:02:07 +0800
From:   Yue Hu <zbestahu@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     devel@...verdev.osuosl.org, yuchao0@...wei.com,
        linux-kernel@...r.kernel.org, huyue2@...ong.com,
        linux-erofs@...ts.ozlabs.org
Subject: Re: [PATCH RESEND v3] staging: erofs: remove unsupported ->datamode
 check in fill_inline_data()

On Thu, 4 Jul 2019 07:26:49 +0200
Greg KH <gregkh@...uxfoundation.org> wrote:

> On Thu, Jul 04, 2019 at 09:59:03AM +0800, Yue Hu wrote:
> > On Wed, 3 Jul 2019 18:20:38 +0200
> > Greg KH <gregkh@...uxfoundation.org> wrote:
> >   
> > > On Tue, Jul 02, 2019 at 10:56:01AM +0800, Yue Hu wrote:  
> > > > From: Yue Hu <huyue2@...ong.com>
> > > > 
> > > > Already check if ->datamode is supported in read_inode(), no need to check
> > > > again in the next fill_inline_data() only called by fill_inode().
> > > > 
> > > > Signed-off-by: Yue Hu <huyue2@...ong.com>
> > > > Reviewed-by: Gao Xiang <gaoxiang25@...wei.com>
> > > > Reviewed-by: Chao Yu <yuchao0@...wei.com>
> > > > ---
> > > > no change
> > > > 
> > > >  drivers/staging/erofs/inode.c | 2 --
> > > >  1 file changed, 2 deletions(-)    
> > > 
> > > This is already in my tree, right?  
> > 
> > Seems not, i have received notes about other 2 patches below mergerd:
> > 
> > ```note1
> > This is a note to let you know that I've just added the patch titled
> > 
> >     staging: erofs: don't check special inode layout
> > 
> > to my staging git tree which can be found at
> >     git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> > in the staging-next branch.
> > ```
> > 
> > ```note2
> > This is a note to let you know that I've just added the patch titled
> > 
> >     staging: erofs: return the error value if fill_inline_data() fails
> > 
> > to my staging git tree which can be found at
> >     git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> > in the staging-next branch.
> > ```
> > 
> > No this patch in below link checked:
> > 
> > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/log/drivers/staging/erofs?h=staging-testing  
> 
> Then if it is not present, it needs to be rebased as it does not apply.
> 
> Please do so and resend it.

Hm, no need to resend since it's included in another patch below.

ec8c244 staging: erofs: add compacted ondisk compression indexes.

Thanks.

> 
> thanks,
> 
> greg k-h