lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 4 Jul 2019 22:49:33 +0900 From: Akinobu Mita <akinobu.mita@...il.com> To: YueHaibing <yuehaibing@...wei.com> Cc: Mark Brown <broonie@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, rafael@...nel.org, wsa+renesas@...g-engineering.com, Sakari Ailus <sakari.ailus@...ux.intel.com>, Mauro Carvalho Chehab <mchehab+samsung@...nel.org>, Jacopo Mondi <jacopo@...ndi.org>, khoroshilov@...ras.ru, LKML <linux-kernel@...r.kernel.org>, Linux Media Mailing List <linux-media@...r.kernel.org> Subject: Re: [PATCH] regmap: select CONFIG_REGMAP while REGMAP_SCCB is set 2019年7月4日(木) 18:36 YueHaibing <yuehaibing@...wei.com>: > > REGMAP_SCCB is selected by ov772x and ov9650 drivers, > but CONFIG_REGMAP may not, so building will fails: > > rivers/media/i2c/ov772x.c: In function ov772x_probe: > drivers/media/i2c/ov772x.c:1360:22: error: variable ov772x_regmap_config has initializer but incomplete type > static const struct regmap_config ov772x_regmap_config = { > ^~~~~~~~~~~~~ > drivers/media/i2c/ov772x.c:1361:4: error: const struct regmap_config has no member named reg_bits > > Reported-by: Hulk Robot <hulkci@...wei.com> > Fixes: 5bbf32217bf9 ("media: ov772x: use SCCB regmap") > Signed-off-by: YueHaibing <yuehaibing@...wei.com> > --- > drivers/base/regmap/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig > index c8bbf53..a498413 100644 > --- a/drivers/base/regmap/Kconfig > +++ b/drivers/base/regmap/Kconfig > @@ -4,7 +4,7 @@ > # subsystems should select the appropriate symbols. > > config REGMAP > - default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W1 || REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_I3C) > + default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W1 || REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_SCCB || REGMAP_I3C) > select IRQ_DOMAIN if REGMAP_IRQ > bool Looks good. Reviewed-by: Akinobu Mita <akinobu.mita@...il.com> A similar problem exists for REGMAP_SOUNDWIRE. But I can't find any users of regmap_init_sdw (i.e. REGMAP_SOUNDWIRE).
Powered by blists - more mailing lists