linux-kernel - Re: [PATCH] tpm: fixes uninitialized allocated banks for IBM vtpm driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <0EDE02C7-3716-47A2-B7B0-007025F28567@linux.vnet.ibm.com>
Date:   Thu, 4 Jul 2019 19:26:36 +0530
From:   Sachin Sant <sachinp@...ux.vnet.ibm.com>
To:     Nayna Jain <nayna@...ux.ibm.com>
Cc:     linux-integrity@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        George Wilson <gcwilson@...ux.ibm.com>,
        linux-kernel@...r.kernel.org,
        Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Peter Huewe <peterhuewe@....de>,
        Michal Suchanek <msuchanek@...e.de>,
        Mimi Zohar <zohar@...ux.ibm.com>
Subject: Re: [PATCH] tpm: fixes uninitialized allocated banks for IBM vtpm
 driver


> On 04-Jul-2019, at 5:29 PM, Mimi Zohar <zohar@...ux.ibm.com> wrote:
> 
> On Wed, 2019-07-03 at 23:32 -0400, Nayna Jain wrote:
>> The nr_allocated_banks and allocated banks are initialized as part of
>> tpm_chip_register. Currently, this is done as part of auto startup
>> function. However, some drivers, like the ibm vtpm driver, do not run
>> auto startup during initialization. This results in uninitialized memory
>> issue and causes a kernel panic during boot.
>> 
>> This patch moves the pcr allocation outside the auto startup function
>> into tpm_chip_register. This ensures that allocated banks are initialized
>> in any case.
>> 
>> Fixes: 879b589210a9 ("tpm: retrieve digest size of unknown algorithms with
>> PCR read")
>> Signed-off-by: Nayna Jain <nayna@...ux.ibm.com>
> Reviewed-by: Mimi Zohar <zohar@...ux.ibm.com>

Thanks for the fix. Kernel boots fine with this fix.

Tested-by: Sachin Sant <sachinp@...ux.vnet.ibm.com>

Thanks
-Sachin