linux-kernel - Re: [PATCH] drm/client: remove the exporting of drm_client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACvgo52N5v07qA_afJfw7vo1X6_Gt4cGqBZn3eBzQtokndjWxA@mail.gmail.com>
Date:   Thu, 4 Jul 2019 15:07:22 +0100
From:   Emil Velikov <emil.l.velikov@...il.com>
To:     Denis Efremov <efremov@...ux.com>
Cc:     Noralf Trønnes <noralf@...nnes.org>,
        ML dri-devel <dri-devel@...ts.freedesktop.org>,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/client: remove the exporting of drm_client_close

On Thu, 4 Jul 2019 at 08:27, Denis Efremov <efremov@...ux.com> wrote:
>
> The function drm_client_close is declared as static and marked as
> EXPORT_SYMBOL. It's a bit confusing for an internal function to be
> exported. The area of visibility for such function is its .c file
> and all other modules. Other *.c files of the same module can't use it,
> despite all other modules can. Relying on the fact that this is the
> internal function and it's not a crucial part of the API, the patch
> removes the EXPORT_SYMBOL marking of drm_client_close.
>
> Signed-off-by: Denis Efremov <efremov@...ux.com>

Nice one:
Reviewed-by: Emil Velikov <emil.velikov@...labora.com>

Out of curiosity: Did you use some tool to spot this?

-Emil