linux-kernel - Re: [Patch v2 02/10] drm/msm: using dev_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACvgo53Dgdx5NhMaOAc9AhfvvbjX17RfuT71bMLR6G4RKhY=AQ@mail.gmail.com>
Date:   Thu, 4 Jul 2019 15:12:23 +0100
From:   Emil Velikov <emil.l.velikov@...il.com>
To:     Fuqian Huang <huangfq.daxian@...il.com>
Cc:     freedreno@...ts.freedesktop.org, David Airlie <airlied@...ux.ie>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        ML dri-devel <dri-devel@...ts.freedesktop.org>,
        Sean Paul <sean@...rly.run>
Subject: Re: [Patch v2 02/10] drm/msm: using dev_get_drvdata directly

On Thu, 4 Jul 2019 at 08:26, Fuqian Huang <huangfq.daxian@...il.com> wrote:
>
> Several drivers cast a struct device pointer to a struct
> platform_device pointer only to then call platform_get_drvdata().
> To improve readability, these constructs can be simplified
> by using dev_get_drvdata() directly.
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@...il.com>

This patch is:
Reviewed-by: Emil Velikov <emil.velikov@...labora.com>

I think you want to add Jordan's ack-by from [1]

-Emil
[1] https://lists.freedesktop.org/archives/dri-devel/2019-July/224928.html