linux-kernel - Re: [PATCH] btrfs: Fix build error while LIBCRC32C is module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190704161949.GZ20977@twin.jikos.cz>
Date:   Thu, 4 Jul 2019 18:19:49 +0200
From:   David Sterba <dsterba@...e.cz>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     clm@...com, josef@...icpanda.com, dsterba@...e.com,
        jthumshirn@...e.de, linux-kernel@...r.kernel.org,
        linux-btrfs@...r.kernel.org
Subject: Re: [PATCH] btrfs: Fix build error while LIBCRC32C is module

On Tue, Jul 02, 2019 at 10:39:03PM +0800, YueHaibing wrote:
> If CONFIG_BTRFS_FS is y and CONFIG_LIBCRC32C is m,
> building fails:
> 
> fs/btrfs/super.o: In function `btrfs_mount_root':
> super.c:(.text+0xb7f9): undefined reference to `crc32c_impl'
> fs/btrfs/super.o: In function `init_btrfs_fs':
> super.c:(.init.text+0x3465): undefined reference to `crc32c_impl'
> fs/btrfs/extent-tree.o: In function `hash_extent_data_ref':
> extent-tree.c:(.text+0xe60): undefined reference to `crc32c'
> extent-tree.c:(.text+0xe78): undefined reference to `crc32c'
> extent-tree.c:(.text+0xe8b): undefined reference to `crc32c'
> fs/btrfs/dir-item.o: In function `btrfs_insert_xattr_item':
> dir-item.c:(.text+0x291): undefined reference to `crc32c'
> fs/btrfs/dir-item.o: In function `btrfs_insert_dir_item':
> dir-item.c:(.text+0x429): undefined reference to `crc32c'
> 
> Select LIBCRC32C to fix it.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: d5178578bcd4 ("btrfs: directly call into crypto framework for checksumming")

Thanks, queued for 5.3.  I hoped we could reduce the config dependencies
a bit, oh well.