linux-kernel - Re: [PATCH] remoteproc: qcom: q6v5-mss: Fix build error without QCOM_MDT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 4 Jul 2019 11:22:05 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     ohad@...ery.com, jeffrey.l.hugo@...il.com, agross@...nel.org,
        linux-kernel@...r.kernel.org, linux-remoteproc@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH] remoteproc: qcom: q6v5-mss: Fix build error without
 QCOM_MDT_LOADER

On Wed 03 Jul 23:46 PDT 2019, YueHaibing wrote:

> If QCOM_Q6V5_MSS is set but QCOM_MDT_LOADER is not,
> building will fails:
> 
> drivers/remoteproc/qcom_q6v5_mss.o: In function `q6v5_start':
> qcom_q6v5_mss.c:(.text+0x3260): undefined reference to `qcom_mdt_read_metadata'
> 
> Add QCOM_MDT_LOADER dependency for QCOM_Q6V5_MSS.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: f04b91383456 ("remoteproc: qcom: q6v5-mss: Support loading non-split images")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Thanks for catching this, Applied.

Regards,
Bjorn

> ---
>  drivers/remoteproc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index 9b0f0cb..28ed306 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -116,6 +116,7 @@ config QCOM_Q6V5_MSS
>  	depends on RPMSG_QCOM_GLINK_SMEM || RPMSG_QCOM_GLINK_SMEM=n
>  	depends on QCOM_SYSMON || QCOM_SYSMON=n
>  	select MFD_SYSCON
> +	select QCOM_MDT_LOADER
>  	select QCOM_Q6V5_COMMON
>  	select QCOM_RPROC_COMMON
>  	select QCOM_SCM
> -- 
> 2.7.4
> 
>