[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190704183432.av37fjd5s3zcho6m@rYz3n>
Date: Thu, 4 Jul 2019 13:34:33 -0500
From: Jiunn Chang <c0d1n61at3@...il.com>
To: Johannes Berg <johannes@...solutions.net>
Cc: Shuah Khan <skhan@...uxfoundation.org>,
linux-kernel-mentees@...ts.linuxfoundation.org,
linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [Linux-kernel-mentees][PATCH v2] nl80211: Fix undefined behavior
in bit shift
On Fri, Jun 28, 2019 at 03:57:05PM +0200, Johannes Berg wrote:
> On Wed, 2019-06-26 at 21:34 -0600, Shuah Khan wrote:
> > On 6/26/19 9:25 PM, Jiunn Chang wrote:
> > > Shifting signed 32-bit value by 31 bits is undefined. Changing most
> > > significant bit to unsigned.
> > >
> > > Changes included in v2:
> > > - use subsystem specific subject lines
> > > - CC required mailing lists
> > >
> > > Signed-off-by: Jiunn Chang <c0d1n61at3@...il.com>
> > > ---
> >
> > Move version change lines here. They don't belong in the commit log.
>
> FWIW, in many cases people (maintainers) now *do* want them in the
> commit log. Here, they're just editorial, so agree, but if real
> technical changes were made due to reviews, they can indeed be useful.
>
> johannes
>
Hello Johannes,
Would you like me to send v3 with the change log in the patch description?
THX,
Jiunn
Powered by blists - more mailing lists