lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 5 Jul 2019 06:29:46 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Lukas Schneider <lukas.s.schneider@....de>
Cc:     kbuild-all@...org, mchehab@...nel.org, gregkh@...uxfoundation.org,
        hverkuil-cisco@...all.nl, st5pub@...dex.ru,
        gabrielfanelli61@...il.com, code@...ofe.uk,
        linux-media@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, Jannik Moritz <jannik.moritz@....de>,
        linux-kernel@...cs.fau.de,
        Lukas Schneider <lukas.s.schneider@....de>
Subject: Re: [PATCH] media: bcm2048: Macros with complex values should be
 enclosed in parentheses

Hi Lukas,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[cannot apply to v5.2-rc7 next-20190704]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Lukas-Schneider/media-bcm2048-Macros-with-complex-values-should-be-enclosed-in-parentheses/20190628-003532
base:   git://linuxtv.org/media_tree.git master
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-6) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/staging/media/bcm2048/radio-bcm2048.c:2004:1: error: expected identifier or '(' before 'do'
    do {         \
    ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2033:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(power_state, unsigned int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/media/bcm2048/radio-bcm2048.c:2007:3: error: expected identifier or '(' before 'while'
    } while (0)        \
      ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2033:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(power_state, unsigned int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/media/bcm2048/radio-bcm2048.c:2007:3: error: expected identifier or '(' before 'while'
    } while (0)        \
      ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2034:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(mute, unsigned int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/media/bcm2048/radio-bcm2048.c:2007:3: error: expected identifier or '(' before 'while'
    } while (0)        \
      ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2035:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(audio_route, unsigned int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/media/bcm2048/radio-bcm2048.c:2007:3: error: expected identifier or '(' before 'while'
    } while (0)        \
      ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2036:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(dac_output, unsigned int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/media/bcm2048/radio-bcm2048.c:2007:3: error: expected identifier or '(' before 'while'
    } while (0)        \
      ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2038:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/media/bcm2048/radio-bcm2048.c:2007:3: error: expected identifier or '(' before 'while'
    } while (0)        \
      ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2039:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/media/bcm2048/radio-bcm2048.c:2007:3: error: expected identifier or '(' before 'while'
    } while (0)        \
      ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2040:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/media/bcm2048/radio-bcm2048.c:2007:3: error: expected identifier or '(' before 'while'
    } while (0)        \
      ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2041:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/media/bcm2048/radio-bcm2048.c:2007:3: error: expected identifier or '(' before 'while'
    } while (0)        \
      ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2042:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/media/bcm2048/radio-bcm2048.c:2007:3: error: expected identifier or '(' before 'while'
    } while (0)        \
      ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2043:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/media/bcm2048/radio-bcm2048.c:2007:3: error: expected identifier or '(' before 'while'
    } while (0)        \
      ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2044:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(fm_search_rssi_threshold, unsigned int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/media/bcm2048/radio-bcm2048.c:2007:3: error: expected identifier or '(' before 'while'
    } while (0)        \
      ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2045:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(fm_search_mode_direction, unsigned int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/media/bcm2048/radio-bcm2048.c:2007:3: error: expected identifier or '(' before 'while'
    } while (0)        \
      ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2046:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(fm_search_tune_mode, unsigned int, "%u", value > 3)
    ^~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/media/bcm2048/radio-bcm2048.c:2007:3: error: expected identifier or '(' before 'while'
    } while (0)        \
      ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2048:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(rds, unsigned int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/media/bcm2048/radio-bcm2048.c:2007:3: error: expected identifier or '(' before 'while'
    } while (0)        \
      ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2049:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(rds_b_block_mask, unsigned int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/media/bcm2048/radio-bcm2048.c:2007:3: error: expected identifier or '(' before 'while'
    } while (0)        \
      ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2050:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(rds_b_block_match, unsigned int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/media/bcm2048/radio-bcm2048.c:2007:3: error: expected identifier or '(' before 'while'
    } while (0)        \
      ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2051:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(rds_pi_mask, unsigned int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/media/bcm2048/radio-bcm2048.c:2007:3: error: expected identifier or '(' before 'while'
    } while (0)        \
      ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2052:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(rds_pi_match, unsigned int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/media/bcm2048/radio-bcm2048.c:2007:3: error: expected identifier or '(' before 'while'
    } while (0)        \
      ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2053:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(rds_wline, unsigned int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~

vim +2004 drivers/staging/media/bcm2048/radio-bcm2048.c

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (68219 bytes)

Powered by blists - more mailing lists