linux-kernel - Re: [PATCH v2] gen_compile_command: Add support for separate KBUILD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNAT5=MhXuaQMksBuuDxi2Xg1oMt1-CyOEvyQTw1FJFEEiA@mail.gmail.com>
Date:   Thu, 4 Jul 2019 14:08:27 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Tom Roeder <tmroeder@...gle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Raul E Rangel <rrangel@...omium.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Tom Hughes <tomhughes@...omium.org>,
        Douglas Anderson <dianders@...omium.org>,
        Ryan Case <ryandcase@...omium.org>,
        Yu Liu <yudiliu@...gle.com>,
        Nathan Chancellor <natechancellor@...il.com>
Subject: Re: [PATCH v2] gen_compile_command: Add support for separate
 KBUILD_OUTPUT directory

On Tue, Jun 25, 2019 at 1:31 AM Matthias Kaehlcke <mka@...omium.org> wrote:
>
> gen_compile_command.py currently assumes that the .cmd files and the
> source code live in the same directory, which is not the case when
> a separate KBUILD_OUTPUT directory is used.
>
> Add a new option to specify this the kbuild output directory. If the
> option is not set the kernel source directory is used.

I do not understand this patch.

In my understanding, this tool already provides
-d, --directory option, which is supposed to point to
the kbuild output directory, not a source directory.


This works except under tools/.



> -                        entry = process_line(directory, dirpath,
> +                        entry = process_line(source_directory, dirpath,
>                                               result.group(1), result.group(2))

This is wrong.

result.group(2) returns the relative path to the output tree
instead of the source tree.
(or absolute path).


[Example of breakage]

$ make -j8 O=foo defconfig all
$ scripts/gen_compile_commands.py  -d .  -k foo
WARNING: Found 0 entries. Have you compiled the kernel?






-- 
Best Regards
Masahiro Yamada