linux-kernel - Re: [PATCH][next] ubifs: remove redundant assignment to pointer fname

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 Jul 2019 09:31:27 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        Richard Weinberger <richard@....at>,
        Artem Bityutskiy <dedekind1@...il.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        linux-mtd@...ts.infradead.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] ubifs: remove redundant assignment to pointer fname

On 05/07/2019 09:24, Sergei Shtylyov wrote:
> Hello!
> 
> On 05.07.2019 1:28, Colin King wrote:
> 
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> The pointer fname rc is being assigned with a value that is never
> 
>    rc?

Oops, cut'n'paste error. Do you want me to resend to can this be fixed
when it's applied?

Colin

> 
>> read because the function returns after the assignment. The assignment
>> is redundant and can be removed.
>>
>> Addresses-Coverity: ("Unused value")
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>> ---
>>   fs/ubifs/debug.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
>> index 92fe5c5ed78a..95da71e13fc8 100644
>> --- a/fs/ubifs/debug.c
>> +++ b/fs/ubifs/debug.c
>> @@ -2817,7 +2817,6 @@ void dbg_debugfs_init_fs(struct ubifs_info *c)
>>                c->vi.ubi_num, c->vi.vol_id);
>>       if (n == UBIFS_DFS_DIR_LEN) {
>>           /* The array size is too small */
>> -        fname = UBIFS_DFS_DIR_NAME;
>>           return;
>>       }
>>   
> 
> MBR, Sergei
>