linux-kernel - Re: [linux-sunxi] [PATCH v3] drivers: ata: ahci_sunxi: Increased SATA/AHCI DMA TX/RX FIFOs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGb2v67OEa+ge7qpbNa5R7DCpgwKfs4T8KHTKe4fnuQYwzJURQ@mail.gmail.com>
Date:   Fri, 5 Jul 2019 16:48:44 +0800
From:   Chen-Yu Tsai <wens@...e.org>
To:     Jens Axboe <axboe@...nel.dk>, Hans de Goede <hdegoede@...hat.com>
Cc:     Maxime Ripard <maxime.ripard@...tlin.com>,
        linux-ide@...r.kernel.org,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Uenal Mutlu <um@...luit.com>,
        linux-sunxi <linux-sunxi@...glegroups.com>,
        linux-amarula <linux-amarula@...rulasolutions.com>,
        Jagan Teki <jagan@...rulasolutions.com>,
        Pablo Greco <pgreco@...tosproject.org>,
        Mark Rutland <mark.rutland@....com>,
        Oliver Schinagl <oliver@...inagl.nl>,
        Linus Walleij <linus.walleij@...aro.org>,
        FUKAUMI Naoki <naobsd@...il.com>,
        Andre Przywara <andre.przywara@....com>,
        Stefan Monnier <monnier@....umontreal.ca>
Subject: Re: [linux-sunxi] [PATCH v3] drivers: ata: ahci_sunxi: Increased
 SATA/AHCI DMA TX/RX FIFOs

On Mon, May 13, 2019 at 10:24 PM Uenal Mutlu <um@...luit.com> wrote:
>
> Increasing the SATA/AHCI DMA TX/RX FIFOs (P0DMACR.TXTS and .RXTS, ie.
> TX_TRANSACTION_SIZE and RX_TRANSACTION_SIZE) from default 0x0 each
> to 0x3 each, gives a write performance boost of 120 MiB/s to 132 MiB/s
> from lame 36 MiB/s to 45 MiB/s previously.
> Read performance is above 200 MiB/s.
> [tested on SSD using dd bs=4K/8K/12K/16K/20K/24K/32K: peak-perf at 12K]
>
> Tested on the SBCs Banana Pi R1 (aka Lamobo R1) and Banana Pi M1 which
> are based on the Allwinner A20 32bit-SoC (ARMv7-a / arm-linux-gnueabihf).
> These devices are RaspberryPi-like small devices.
>
> This problem of slow SATA write-speed with these small devices lasts
> for about 7 years now (beginning with the A10 SoC). Many commentators
> throughout the years wrongly assumed the slow write speed was a
> hardware limitation. This patch finally solves the problem, which
> in fact was just a hard-to-find software problem due to lack of
> SATA/AHCI documentation by the SoC-maker Allwinner Technology.
>
> Lists of the affected sunxi and other boards and SoCs with SATA using
> the ahci_sunxi driver:
>   $ grep -i -e "^&ahci" arch/arm/boot/dts/sun*dts
>   and http://linux-sunxi.org/SATA#Devices_with_SATA_ports
>   See also http://linux-sunxi.org/Category:Devices_with_SATA_port
>
> Acked-by: Maxime Ripard <maxime.ripard@...tlin.com>
> Reviewed-by: Hans de Goede <hdegoede@...hat.com>
> Signed-off-by: Uenal Mutlu <um@...luit.com>

Tested-by: Chen-Yu Tsai <wens@...e.org>

on a Lamabo R1 as well.

Maybe we could merge this soon so it makes the next merge window?

Thanks.