linux-kernel - Re: [PATCH] ALSA: cs4281: remove redundant assignment to variable val and remove a goto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hh880zt5p.wl-tiwai@suse.de>
Date:   Fri, 05 Jul 2019 12:12:50 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Colin King <colin.king@...onical.com>
Cc:     <alsa-devel@...a-project.org>, Jaroslav Kysela <perex@...ex.cz>,
        "Takashi Iwai" <tiwai@...e.com>, <kernel-janitors@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: cs4281: remove redundant assignment to variable val and remove a goto

On Fri, 05 Jul 2019 11:57:04 +0200,
Colin King wrote:
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> The variable val is being assigned with a value that is never
> read and it is being updated later with a new value. The
> assignment is redundant and can be removed.  Also remove a
> goto statement and a label and replace with a break statement.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thanks.


Takashi