[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAGngYiVsUZwCUEsqRk-YtZPGYxsqzHzD7U5GeeHyAa2Yw9Z6WA@mail.gmail.com>
Date: Fri, 5 Jul 2019 08:26:12 -0400
From: Sven Van Asbroeck <thesven73@...il.com>
To: Vinod Koul <vkoul@...nel.org>
Cc: Robin Gong <yibin.gong@....com>,
Dan Williams <dan.j.williams@...el.com>,
Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
NXP Linux Team <linux-imx@....com>,
dmaengine@...r.kernel.org,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@...ts.infradead.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dmaengine: imx-sdma: fix use-after-free on probe error path
Hi Vinod,
On Fri, Jul 5, 2019 at 3:32 AM Vinod Koul <vkoul@...nel.org> wrote:
>
> > + if (ret)
> > + dev_warn(&pdev->dev, "failed to get firmware name\n");
>
> if should have braces!
> Applied after fixing braces!
checkpatch.pl output after adding braces:
WARNING: braces {} are not necessary for single statement blocks
#102: FILE: drivers/dma/imx-sdma.c:2165:
+ if (ret) {
+ dev_warn(&pdev->dev, "failed to get firmware from device tree\n");
+ }
total: 0 errors, 1 warnings, 61 lines checked
Powered by blists - more mailing lists