[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190705124151.GN5942@intel.com>
Date: Fri, 5 Jul 2019 15:41:51 +0300
From: Ville Syrjälä <ville.syrjala@...ux.intel.com>
To: YueHaibing <yuehaibing@...wei.com>
Cc: jani.nikula@...ux.intel.com, joonas.lahtinen@...ux.intel.com,
rodrigo.vivi@...el.com, airlied@...ux.ie, daniel@...ll.ch,
imre.deak@...el.com, dhinakaran.pandiyan@...el.com,
chris@...is-wilson.co.uk, manasi.d.navare@...el.com,
intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH -next] drm/i915: Remove set but not used variable
'encoder'
On Fri, Jul 05, 2019 at 11:31:12AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/i915/display/intel_dp.c: In function 'intel_dp_set_drrs_state':
> drivers/gpu/drm/i915/display/intel_dp.c:6623:24: warning:
> variable 'encoder' set but not used [-Wunused-but-set-variable]
>
> It's never used, so can be removed.Also remove related
> variable 'dig_port'
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
Applied to drm-intel-next-queued. Thanks for the patch.
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 8f7188d71d08..0bdb7ecc5a81 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -6620,8 +6620,6 @@ static void intel_dp_set_drrs_state(struct drm_i915_private *dev_priv,
> const struct intel_crtc_state *crtc_state,
> int refresh_rate)
> {
> - struct intel_encoder *encoder;
> - struct intel_digital_port *dig_port = NULL;
> struct intel_dp *intel_dp = dev_priv->drrs.dp;
> struct intel_crtc *intel_crtc = to_intel_crtc(crtc_state->base.crtc);
> enum drrs_refresh_rate_type index = DRRS_HIGH_RR;
> @@ -6636,9 +6634,6 @@ static void intel_dp_set_drrs_state(struct drm_i915_private *dev_priv,
> return;
> }
>
> - dig_port = dp_to_dig_port(intel_dp);
> - encoder = &dig_port->base;
> -
> if (!intel_crtc) {
> DRM_DEBUG_KMS("DRRS: intel_crtc not initialized\n");
> return;
>
>
--
Ville Syrjälä
Intel
Powered by blists - more mailing lists