linux-kernel - [PATCH] m68k: One function call less in cf_tlb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5713aa4-d290-0f7d-7de8-82bcdf74ee95@web.de>
Date:   Fri, 5 Jul 2019 17:18:12 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     linux-m68k@...ts.linux-m68k.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Greg Ungerer <gerg@...ux-m68k.org>,
        Michal Hocko <mhocko@...e.com>,
        Mike Rapoport <rppt@...ux.ibm.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: [PATCH] m68k: One function call less in cf_tlb_miss()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Fri, 5 Jul 2019 17:11:37 +0200

Avoid an extra function call by using a ternary operator instead of
a conditional statement for a setting selection.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 arch/m68k/mm/mcfmmu.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/arch/m68k/mm/mcfmmu.c b/arch/m68k/mm/mcfmmu.c
index 6cb1e41d58d0..02fc0778028e 100644
--- a/arch/m68k/mm/mcfmmu.c
+++ b/arch/m68k/mm/mcfmmu.c
@@ -146,12 +146,10 @@ int cf_tlb_miss(struct pt_regs *regs, int write, int dtlb, int extension_word)

 	mmu_write(MMUDR, (pte_val(*pte) & PAGE_MASK) |
 		((pte->pte) & CF_PAGE_MMUDR_MASK) | MMUDR_SZ_8KB | MMUDR_X);
-
-	if (dtlb)
-		mmu_write(MMUOR, MMUOR_ACC | MMUOR_UAA);
-	else
-		mmu_write(MMUOR, MMUOR_ITLB | MMUOR_ACC | MMUOR_UAA);
-
+	mmu_write(MMUOR,
+		  dtlb
+		  ? MMUOR_ACC | MMUOR_UAA
+		  : MMUOR_ITLB | MMUOR_ACC | MMUOR_UAA);
 	local_irq_restore(flags);
 	return 0;
 }
--
2.22.0