linux-kernel - Re: [PATCH v6 2/2] KVM: LAPIC: Inject timer interrupt via posted interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <da981f5f-fa62-f0a2-a530-5aa59ab1a38e@redhat.com>
Date:   Fri, 5 Jul 2019 18:04:09 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Wanpeng Li <kernellwp@...il.com>, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org
Cc:     Radim Krčmář <rkrcmar@...hat.com>,
        Marcelo Tosatti <mtosatti@...hat.com>
Subject: Re: [PATCH v6 2/2] KVM: LAPIC: Inject timer interrupt via posted
 interrupt

On 05/07/19 16:52, Wanpeng Li wrote:
>  
> -void kvm_wait_lapic_expire(struct kvm_vcpu *vcpu)
> +void kvm_wait_lapic_expire(struct kvm_vcpu *vcpu, bool pi_inject)
>  {
>  	struct kvm_lapic *apic = vcpu->arch.apic;
>  	u64 guest_tsc, tsc_deadline;
> @@ -1539,7 +1570,7 @@ void kvm_wait_lapic_expire(struct kvm_vcpu *vcpu)
>  	if (apic->lapic_timer.expired_tscdeadline == 0)
>  		return;
>  
> -	if (!lapic_timer_int_injected(vcpu))
> +	if (!lapic_timer_int_injected(vcpu) && !pi_inject)
>  		return;
>  

What is the reason for this other bool argument?  (Yes, I hate bool
arguments...).

Paolo