linux-kernel - Re: [tip:irq/core] gpio: mb86s7x: Enable ACPI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKv+Gu9cZamcgFgzQP7ZX27jYNnFJG8XDPy+RwsZB_zfWsGNAw@mail.gmail.com>
Date:   Fri, 5 Jul 2019 19:53:14 +0200
From:   Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Marc Zyngier <marc.zyngier@....com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        linux-tip-commits@...r.kernel.org
Subject: Re: [tip:irq/core] gpio: mb86s7x: Enable ACPI support

On Fri, 5 Jul 2019 at 10:58, Linus Walleij <linus.walleij@...aro.org> wrote:
>
> On Thu, Jul 4, 2019 at 8:18 PM Ard Biesheuvel <ard.biesheuvel@...aro.org> wrote:
> > On Thu, 4 Jul 2019 at 09:52, Linus Walleij <linus.walleij@...aro.org> wrote:
> > >
> > > On Wed, Jul 3, 2019 at 3:50 PM Marc Zyngier <marc.zyngier@....com> wrote:
> > > > On 03/07/2019 13:26, Linus Walleij wrote:
> > > > > On Wed, Jul 3, 2019 at 11:24 AM tip-bot for Ard Biesheuvel
> > > > > <tipbot@...or.com> wrote:
> > > > >
> > > > >> Committer:  Marc Zyngier <marc.zyngier@....com>
> > > > >> CommitDate: Wed, 29 May 2019 10:42:19 +0100
> > > > >>
> > > > >> gpio: mb86s7x: Enable ACPI support
> > > > >>
> > > > >> Make the mb86s7x GPIO block discoverable via ACPI. In addition, add
> > > > >> support for ACPI GPIO interrupts routed via platform interrupts, by
> > > > >> wiring the two together via the to_irq() gpiochip callback.
> > > > >>
> > > > >> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> > > > >> Reviewed-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> > > > >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>
> > > > >> Signed-off-by: Marc Zyngier <marc.zyngier@....com>
> > > > >
> > > > > OK!
> > > > >
> > > > >> +#include "gpiolib.h"
> > > > >> +
> > > > >
> > > > > But this isn't needed anymore, is it?
> > > >
> > > > You tell me! ;-)
> > > >
> > > > > I can try to remember to remove it later though.
> > > >
> > > > Yeah, please send a separate patch. tip is stable, and we can't roll
> > > > this back.
> > >
> > > I'll just fix it in the GPIO tree after -rc1.
> > > Made a personal TODO note!
> >
> > Why wouldn't it be needed anymore?
>
> I looked over the code like 5 times and I can't see it touching any
> gpiolib internals anymore, but maybe I'm still wrong?
>
> Normally GPIO drivers should get all symbols it needs from
> <linux/gpio/driver.h> and "gpiolib.h" is not something drivers
> should include.
>
> Anyways I will get to know from compile tests if I'm wrong.
>

IIRC it had something to do with the ACPI helpers that this driver
calls directly.