linux-kernel - Re: [PATCH] xtensa: One function call less in bootmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMo8BfK_VuL4-xtmY+jYDmrJ-t9a-AyPNCxS7-Db4HzAqpr_BA@mail.gmail.com>
Date:   Fri, 5 Jul 2019 12:06:51 -0700
From:   Max Filippov <jcmvbkbc@...il.com>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Chris Zankel <chris@...kel.net>,
        Michal Hocko <mhocko@...e.com>,
        Mike Rapoport <rppt@...ux.ibm.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] xtensa: One function call less in bootmem_init()

Hi Markus,

On Fri, Jul 5, 2019 at 9:43 AM Markus Elfring <Markus.Elfring@....de> wrote:
>
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Fri, 5 Jul 2019 18:33:58 +0200
>
> Avoid an extra function call by using a ternary operator instead of
> a conditional statement for a setting selection.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  arch/xtensa/mm/init.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Thanks for the patch. It doesn't change generated code since
PHYS_OFFSET is a build-time constant, but it's a nice cleanup.
Applied to my xtensa tree.

-- 
Thanks.
-- Max