[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190705204537.GC19023@42.do-not-panic.com>
Date: Fri, 5 Jul 2019 20:45:37 +0000
From: Luis Chamberlain <mcgrof@...nel.org>
To: Brendan Higgins <brendanhiggins@...gle.com>
Cc: frowand.list@...il.com, gregkh@...uxfoundation.org,
jpoimboe@...hat.com, keescook@...gle.com,
kieran.bingham@...asonboard.com, peterz@...radead.org,
robh@...nel.org, sboyd@...nel.org, shuah@...nel.org, tytso@....edu,
yamada.masahiro@...ionext.com, devicetree@...r.kernel.org,
dri-devel@...ts.freedesktop.org, kunit-dev@...glegroups.com,
linux-doc@...r.kernel.org, linux-fsdevel@...r.kernel.org,
linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-kselftest@...r.kernel.org, linux-nvdimm@...ts.01.org,
linux-um@...ts.infradead.org, Alexander.Levin@...rosoft.com,
Tim.Bird@...y.com, amir73il@...il.com, dan.carpenter@...cle.com,
daniel@...ll.ch, jdike@...toit.com, joel@....id.au,
julia.lawall@...6.fr, khilman@...libre.com, knut.omang@...cle.com,
logang@...tatee.com, mpe@...erman.id.au, pmladek@...e.com,
rdunlap@...radead.org, richard@....at, rientjes@...gle.com,
rostedt@...dmis.org, wfg@...ux.intel.com
Subject: Re: [PATCH v6 02/18] kunit: test: add test resource management API
On Wed, Jul 03, 2019 at 05:35:59PM -0700, Brendan Higgins wrote:
> diff --git a/kunit/test.c b/kunit/test.c
> index c030ba5a43e40..a70fbe449e922 100644
> --- a/kunit/test.c
> +++ b/kunit/test.c
> @@ -122,7 +122,8 @@ static void kunit_print_test_case_ok_not_ok(struct kunit_case *test_case,
>
> void kunit_init_test(struct kunit *test, const char *name)
> {
> - spin_lock_init(&test->lock);
Once you re-spin, this above line should be removed.
> + mutex_init(&test->lock);
> + INIT_LIST_HEAD(&test->resources);
> test->name = name;
> test->success = true;
> }
Luis
Powered by blists - more mailing lists