[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.21.1907052342250.3648@nanos.tec.linutronix.de>
Date: Fri, 5 Jul 2019 23:43:44 +0200 (CEST)
From: Thomas Gleixner <tglx@...utronix.de>
To: LKML <linux-kernel@...r.kernel.org>
cc: x86@...nel.org, Nadav Amit <namit@...are.com>,
Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>,
Stephane Eranian <eranian@...gle.com>,
Feng Tang <feng.tang@...el.com>
Subject: Re: [patch V2 01/25] x86/kgbd: Use NMI_VECTOR not APIC_DM_NMI
On Thu, 4 Jul 2019, Thomas Gleixner wrote:
> apic->send_IPI_allbutself() takes a vector number as argument.
>
> APIC_DM_NMI is clearly not a vector number. It's defined to 0x400 which is
> outside the vector space.
>
> Use NMI_VECTOR instead as that's what it is intended to be.
>
> Fixes: 82da3ff89dc2 ("x86: kgdb support")
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> ---
> V2: New patch
> ---
> arch/x86/kernel/kgdb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/x86/kernel/kgdb.c
> +++ b/arch/x86/kernel/kgdb.c
> @@ -424,7 +424,7 @@ static void kgdb_disable_hw_debug(struct
> */
> void kgdb_roundup_cpus(void)
> {
> - apic->send_IPI_allbutself(APIC_DM_NMI);
> + apic->send_IPI_allbutself(VECTOR_NMI);
The changelog got it right, but this here needs to be VECTOR_NMI. While I
didn't 0-day was able to find and turn on the config option ...
/blush
Powered by blists - more mailing lists