lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 6 Jul 2019 17:42:56 +0200
From:   Greg Kroah-Hartman <>
Cc:     Stephen Rothwell <>,
        "Rafael J. Wysocki" <>,
        Mark Brown <>, Takashi Iwai <>
Subject: [PATCH] debugfs: make error message a bit more verbose

When a file/directory is already present in debugfs, and it is attempted
to be created again, be more specific about what file/directory is being
created and where it is trying to be created to give a bit more help to
developers to figure out the problem.

Cc: Stephen Rothwell <>
Cc: Rafael J. Wysocki <>
Cc: Mark Brown <>
Cc: Takashi Iwai <>
Signed-off-by: Greg Kroah-Hartman <>
 fs/debugfs/inode.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
index 7f43c8acfcbf..5836312269e0 100644
--- a/fs/debugfs/inode.c
+++ b/fs/debugfs/inode.c
@@ -311,8 +311,13 @@ static struct dentry *start_creating(const char *name, struct dentry *parent)
 	dentry = lookup_one_len(name, parent, strlen(name));
 	if (!IS_ERR(dentry) && d_really_is_positive(dentry)) {
+		if (d_is_dir(dentry))
+			pr_err("Directory '%s' with parent '%s' already present!\n",
+			       name, parent->;
+		else
+			pr_err("File '%s' in directory '%s' already present!\n",
+			       name, parent->;
-		pr_err("File '%s' already present!\n", name);
 		dentry = ERR_PTR(-EEXIST);

Powered by blists - more mailing lists