linux-kernel - Aw: Re: Re: [PATCH v2 3/7] rtc: mt6397: improvements of rtc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 6 Jul 2019 18:15:20 +0200
From:   "Frank Wunderlich" <frank-w@...lic-files.de>
To:     "Alexandre Belloni" <alexandre.belloni@...tlin.com>
Cc:     "Lee Jones" <lee.jones@...aro.org>,
        "Rob Herring" <robh+dt@...nel.org>,
        "Mark Rutland" <mark.rutland@....com>,
        "Matthias Brugger" <matthias.bgg@...il.com>,
        "Sean Wang" <sean.wang@...iatek.com>,
        "Sebastian Reichel" <sre@...nel.org>,
        "Alessandro Zummo" <a.zummo@...ertech.it>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org, linux-rtc@...r.kernel.org,
        "Eddie Huang" <eddie.huang@...iatek.com>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        "Richard Fontana" <rfontana@...hat.com>,
        "Allison Randal" <allison@...utok.net>,
        "David S . Miller" <davem@...emloft.net>,
        "Mauro Carvalho Chehab" <mchehab+samsung@...nel.org>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "Rob Herring" <robh@...nel.org>,
        "Linus Walleij" <linus.walleij@...aro.org>,
        "Nicolas Ferre" <nicolas.ferre@...rochip.com>,
        "Paul E . McKenney" <paulmck@...ux.ibm.com>,
        "Josef Friedl" <josef.friedl@...ed.at>
Subject: Aw: Re: Re: [PATCH v2 3/7] rtc: mt6397: improvements of rtc driver

> Gesendet: Freitag, 05. Juli 2019 um 23:24 Uhr
> Von: "Alexandre Belloni" <alexandre.belloni@...tlin.com>

> Let's say the RTC has been used to start your platform, then the irq
> handler will be called as soon as the irq is requested, leading to a
> null pointer dereference.

i cannot test this with my platform, but i have changed it in my repo

https://github.com/frank-w/BPI-R2-4.14/commits/5.2-poweroff-mainline

> Yes and IIRC, I did comment that the rtc change also had to be separated
> from 1/7.

also this is put in separate commit, can you take a look before i post v3?

> Also, I really doubt this new compatible is necessary at all as you
> could simply directly use mediatek,mt6397-rtc.

imho this can confuse because the wrong chip-name is used in dts

regards Frank