lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 6 Jul 2019 12:35:39 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Vladis Dronov <vdronov@...hat.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
        syzbot+79337b501d6aa974d0f6@...kaller.appspotmail.com,
        stable@...r.kernel.org, Loic Poulain <loic.poulain@...el.com>,
        Ilya Faenson <ifaenson@...adcom.com>
Subject: Re: [PATCH] Bluetooth: hci_ldisc: check for missing tty operations

Hi Vladis,

> Certain ttys lack operations (eg: pty_unix98_ops) which still can be
> called by certain hci uart proto (eg: mrvl, ath). Currently this leads
> to execution at address 0x0. Fix this by adding checks for missing tty
> operations.

so I really prefer that we just fail setting the line discipline. These drivers need to check that the underlying transport has all the operations available they need. We can not just ignore them.

Regards

Marcel

Powered by blists - more mailing lists