linux-kernel - Re: [PATCH] bluetooth: hci_ll: Refactor download

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <25689519-DE1B-4BB6-9C36-4C73F2895E07@holtmann.org>
Date:   Sat, 6 Jul 2019 12:51:28 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Fabian Schindlatz <fabian.schindlatz@....de>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
        Thomas Röthenbacher <thomas.roethenbacher@....de>
Subject: Re: [PATCH] bluetooth: hci_ll: Refactor download_firmware

Hi Fabian,

> Extract the new function send_command_from_firmware from
> download_firmware, which helps with the readability of the switch
> statement. This way the code is less deeply nested and also no longer
> exceeds the 80 character limit.
> 
> Co-developed-by: Thomas Röthenbacher <thomas.roethenbacher@....de>
> Signed-off-by: Thomas Röthenbacher <thomas.roethenbacher@....de>
> Signed-off-by: Fabian Schindlatz <fabian.schindlatz@....de>
> ---
> drivers/bluetooth/hci_ll.c | 45 ++++++++++++++++++++++++--------------
> 1 file changed, 28 insertions(+), 17 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel