[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 07 Jul 2019 17:54:17 +0100
From: Ben Hutchings <ben@...adent.org.uk>
To: linux-kernel@...r.kernel.org, stable@...r.kernel.org
CC: akpm@...ux-foundation.org, Denis Kirjanov <kda@...ux-powerpc.org>,
"Jacek Anaszewski" <jacek.anaszewski@...il.com>,
"Sylwester Nawrocki" <s.nawrocki@...sung.com>,
"Mauro Carvalho Chehab" <mchehab+samsung@...nel.org>,
"Pawe? Chmiel" <pawel.mikolaj.chmiel@...il.com>,
"Hans Verkuil" <hverkuil-cisco@...all.nl>
Subject: [PATCH 3.16 027/129] media: s5p-jpeg: Correct step and max values
for V4L2_CID_JPEG_RESTART_INTERVAL
3.16.70-rc1 review patch. If anyone has any objections, please let me know.
------------------
From: Pawe? Chmiel <pawel.mikolaj.chmiel@...il.com>
commit 19c624c6b29e244c418f8b44a711cbf5e82e3cd4 upstream.
This commit corrects max and step values for v4l2 control for
V4L2_CID_JPEG_RESTART_INTERVAL. Max should be 0xffff and step should be 1.
It was found by using v4l2-compliance tool and checking result of
VIDIOC_QUERY_EXT_CTRL/QUERYMENU test.
Previously it was complaining that step was bigger than difference
between max and min.
Fixes: 15f4bc3b1f42 ("[media] s5p-jpeg: Add JPEG controls support")
Signed-off-by: Pawe? Chmiel <pawel.mikolaj.chmiel@...il.com>
Reviewed-by: Jacek Anaszewski <jacek.anaszewski@...il.com>
Reviewed-by: Sylwester Nawrocki <s.nawrocki@...sung.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@...all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
---
drivers/media/platform/s5p-jpeg/jpeg-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/media/platform/s5p-jpeg/jpeg-core.c
+++ b/drivers/media/platform/s5p-jpeg/jpeg-core.c
@@ -1363,7 +1363,7 @@ static int s5p_jpeg_controls_create(stru
v4l2_ctrl_new_std(&ctx->ctrl_handler, &s5p_jpeg_ctrl_ops,
V4L2_CID_JPEG_RESTART_INTERVAL,
- 0, 3, 0xffff, 0);
+ 0, 0xffff, 1, 0);
if (ctx->jpeg->variant->version == SJPEG_S5P)
mask = ~0x06; /* 422, 420 */
}
Powered by blists - more mailing lists