[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 07 Jul 2019 17:54:17 +0100
From: Ben Hutchings <ben@...adent.org.uk>
To: linux-kernel@...r.kernel.org, stable@...r.kernel.org
CC: akpm@...ux-foundation.org, Denis Kirjanov <kda@...ux-powerpc.org>,
"Stephen Boyd" <sboyd@...nel.org>,
"Yangtao Li" <tiny.windzz@...il.com>
Subject: [PATCH 3.16 004/129] clk: highbank: fix refcount leak in
hb_clk_init()
3.16.70-rc1 review patch. If anyone has any objections, please let me know.
------------------
From: Yangtao Li <tiny.windzz@...il.com>
commit 5eb8ba90958de1285120dae5d3a5d2b1a360b3b4 upstream.
The of_find_compatible_node() returns a node pointer with refcount
incremented, but there is the lack of use of the of_node_put() when
done. Add the missing of_node_put() to release the refcount.
Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
Fixes: 26cae166cff9 ("ARM: highbank: remove custom .init_time hook")
Signed-off-by: Stephen Boyd <sboyd@...nel.org>
Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
---
drivers/clk/clk-highbank.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/clk/clk-highbank.c
+++ b/drivers/clk/clk-highbank.c
@@ -293,6 +293,7 @@ static __init struct clk *hb_clk_init(st
/* Map system registers */
srnp = of_find_compatible_node(NULL, NULL, "calxeda,hb-sregs");
hb_clk->reg = of_iomap(srnp, 0);
+ of_node_put(srnp);
BUG_ON(!hb_clk->reg);
hb_clk->reg += reg;
Powered by blists - more mailing lists