[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 07 Jul 2019 17:54:17 +0100
From: Ben Hutchings <ben@...adent.org.uk>
To: linux-kernel@...r.kernel.org, stable@...r.kernel.org
CC: akpm@...ux-foundation.org, Denis Kirjanov <kda@...ux-powerpc.org>,
"Gregory CLEMENT" <gregory.clement@...tlin.com>,
"Stephen Boyd" <sboyd@...nel.org>,
"Yangtao Li" <tiny.windzz@...il.com>
Subject: [PATCH 3.16 012/129] clk: armada-xp: fix refcount leak in
axp_clk_init()
3.16.70-rc1 review patch. If anyone has any objections, please let me know.
------------------
From: Yangtao Li <tiny.windzz@...il.com>
commit db20a90a4b6745dad62753f8bd2f66afdd5abc84 upstream.
The of_find_compatible_node() returns a node pointer with refcount
incremented, but there is the lack of use of the of_node_put() when
done. Add the missing of_node_put() to release the refcount.
Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
Reviewed-by: Gregory CLEMENT <gregory.clement@...tlin.com>
Fixes: 0a11a6ae9437 ("clk: mvebu: armada-xp: maintain clock init order")
Signed-off-by: Stephen Boyd <sboyd@...nel.org>
Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
---
drivers/clk/mvebu/armada-xp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- a/drivers/clk/mvebu/armada-xp.c
+++ b/drivers/clk/mvebu/armada-xp.c
@@ -202,7 +202,9 @@ static void __init axp_clk_init(struct d
mvebu_coreclk_setup(np, &axp_coreclks);
- if (cgnp)
+ if (cgnp) {
mvebu_clk_gating_setup(cgnp, axp_gating_desc);
+ of_node_put(cgnp);
+ }
}
CLK_OF_DECLARE(axp_clk, "marvell,armada-xp-core-clock", axp_clk_init);
Powered by blists - more mailing lists