linux-kernel - Re: ipc/sem: Three function calls less in do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 7 Jul 2019 09:09:31 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Colin Ian King <colin.king@...onical.com>,
        kernel-janitors@...r.kernel.org
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Arnd Bergmann <arnd@...db.de>,
        Davidlohr Bueso <dave@...olabs.net>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Manfred Spraul <manfred@...orfullife.com>,
        Mathieu Malaterre <malat@...ian.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: ipc/sem: Three function calls less in do_semtimedop()

>> +		list_add_tail(&queue.list,
>> +			      alter
>> +			      ? (sma->complex_count
>> +				? &sma->pending_alter
>> +				: &curr->pending_alter)
>> +			      : &curr->pending_const);
>
> Just no. This is making the code harder to comprehend

This can be according to your current view.


> with no advantage.

I propose to take additional aspects into account for the interpretation
of such source code.
The shown design direction can provide benefits which might get
a lower value for the software development attention so far.


>> +		list_add_tail(&queue.list,
>> +			      alter ? &sma->pending_alter : &sma->pending_const);

Can this code variant look more succinct?

Regards,
Markus