linux-kernel - [PATCH] rtc: bd70528: add dependency to fix build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <420b921d-10ca-1d9a-ac46-5969a7f0e0b9@infradead.org>
Date:   Sun, 7 Jul 2019 09:12:46 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     LKML <linux-kernel@...r.kernel.org>, linux-rtc@...r.kernel.org
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Lee Jones <lee.jones@...aro.org>,
        Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
Subject: [PATCH] rtc: bd70528: add dependency to fix build errors

From: Randy Dunlap <rdunlap@...radead.org>

Fix build errors when MFD_ROHM_BD70528=m, BD70528_WATCHDOG=m,
and RTC_DRV_BD70528=y.  Fixes these build errors:

ld: drivers/rtc/rtc-bd70528.o: in function `bd70528_alm_enable':
rtc-bd70528.c:(.text+0x3a2): undefined reference to `bd70528_wdt_lock'
ld: rtc-bd70528.c:(.text+0x3f8): undefined reference to `bd70528_wdt_unlock'
ld: drivers/rtc/rtc-bd70528.o: in function `bd70528_set_rtc_based_timers':
rtc-bd70528.c:(.text+0x41c): undefined reference to `bd70528_wdt_set'
ld: drivers/rtc/rtc-bd70528.o: in function `bd70528_set_time':
rtc-bd70528.c:(.text+0x500): undefined reference to `bd70528_wdt_lock'
ld: rtc-bd70528.c:(.text+0x587): undefined reference to `bd70528_wdt_unlock'

Also add a blank line to separate the Kconfig entry from the one
above it.

Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Lee Jones <lee.jones@...aro.org>
Cc: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
Cc: linux-rtc@...r.kernel.org
Cc: Andrew Morton <akpm@...ux-foundation.org>
---
Found in mmotm but applies to linux-next.

 drivers/rtc/Kconfig |    2 ++
 1 file changed, 2 insertions(+)

--- mmotm-2019-0706-2200.orig/drivers/rtc/Kconfig
+++ mmotm-2019-0706-2200/drivers/rtc/Kconfig
@@ -498,8 +498,10 @@ config RTC_DRV_M41T80_WDT
 	help
 	  If you say Y here you will get support for the
 	  watchdog timer in the ST M41T60 and M41T80 RTC chips series.
+
 config RTC_DRV_BD70528
 	tristate "ROHM BD70528 PMIC RTC"
+	depends on MFD_ROHM_BD70528
 	help
 	  If you say Y here you will get support for the RTC
 	  on ROHM BD70528 Power Management IC.