linux-kernel - Re: [PATCH 2/2] amdgpu: make SOC15/navi support conditional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a1m-aDAsiVFYyQcoq0a=Y8rA5R3P5TSuBfmK2Gync-8eQ@mail.gmail.com>
Date:   Mon, 8 Jul 2019 18:08:21 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Alex Deucher <alexdeucher@...il.com>
Cc:     Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        "David (ChunMing) Zhou" <David1.Zhou@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Oded Gabbay <oded.gabbay@...il.com>,
        Philip Yang <Philip.Yang@....com>,
        Jack Xiao <Jack.Xiao@....com>, Evan Quan <evan.quan@....com>,
        Yong Zhao <Yong.Zhao@....com>, Amber Lin <Amber.Lin@....com>,
        Feifei Xu <Feifei.Xu@....com>,
        Felix Kuehling <Felix.Kuehling@....com>,
        xinhui pan <xinhui.pan@....com>,
        LKML <linux-kernel@...r.kernel.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        Emily Deng <Emily.Deng@....com>, Huang Rui <ray.huang@....com>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>, Rex Zhu <Rex.Zhu@....com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Shaoyun Liu <Shaoyun.Liu@....com>, Oak Zeng <Oak.Zeng@....com>,
        Hawking Zhang <Hawking.Zhang@....com>
Subject: Re: [PATCH 2/2] amdgpu: make SOC15/navi support conditional

On Mon, Jul 8, 2019 at 4:46 PM Alex Deucher <alexdeucher@...il.com> wrote:
>
> On Mon, Jul 8, 2019 at 10:42 AM Arnd Bergmann <arnd@...db.de> wrote:
> >
> > Enabling amdgpu but not CONFIG_DRM_AMD_DC leads to a warning:
> >
> > drivers/gpu/drm/amd/amdgpu/nv.c: In function 'nv_set_ip_blocks':
> > drivers/gpu/drm/amd/amdgpu/nv.c:400:3: error: #warning "Enable CONFIG_DRM_AMD_DC for display support on navi." [-Werror=cpp]
> >  # warning "Enable CONFIG_DRM_AMD_DC for display support on navi."
> >    ^~~~~~~
> > drivers/gpu/drm/amd/amdgpu/soc15.c: In function 'soc15_set_ip_blocks':
> > drivers/gpu/drm/amd/amdgpu/soc15.c:653:3: error: #warning "Enable CONFIG_DRM_AMD_DC for display support on SOC15." [-Werror=cpp]
> >
> > However, CONFIG_DRM_AMD_DC can only be enabled on x86, so we
> > cannot do that when building for other architectures.
>
> DC is not limited to x86.

Ah, right, only DRM_AMD_DC_DCN1_0 is x86-only.

>  I can drop the warning if that is the concern.

That would be great, yes.

      Arnd