linux-kernel - Re: [PATCH 3/3] platform//x86/pcengines-apuv2: update gpio button definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 Jul 2019 21:27:57 +0200
From:   "Enrico Weigelt, metux IT consult" <lkml@...ux.net>
To:     Florian Eckert <fe@....tdt.de>, Eckert.Florian@...glemail.com,
        info@...ux.net, dvhart@...radead.org, andy@...radead.org
Cc:     platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] platform//x86/pcengines-apuv2: update gpio button
 definition

On 04.07.19 11:02, Florian Eckert wrote:
> * Add the gpio number, so the button subsystem can find the right gpio.
> * Change also the keycode from KEY_SETUP to KEY_RESTART, because it
>   seems more expressive to me and in the Alix-Board, which is the
>   predecessor, there isthis keycode defined too. I think this is also
>   intended by Pcengines. Also many embedded systems defined in the kernel
>   use this key code as well.

In general, I'm not opposed to that, but I'll first have to check trough
various userland code to make sure that it doesn't break
anything in the field, before I can give my ack.


--mtx

-- 
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@...ux.net -- +49-151-27565287