linux-kernel - Re: [PATCH v2] gpu/drm_memory: fix a few warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1907082150170.1961@nanos.tec.linutronix.de>
Date:   Mon, 8 Jul 2019 21:57:58 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Qian Cai <cai@....pw>
cc:     Ilia Mirkin <imirkin@...m.mit.edu>,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Sean Paul <sean@...rly.run>, joe@...ches.com,
        linux-spdx@...r.kernel.org,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>, rfontana@...hat.com,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Jonathan Corbet <corbet@....net>,
        Greg KH <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v2] gpu/drm_memory: fix a few warnings

On Mon, 8 Jul 2019, Qian Cai wrote:
> On Mon, 2019-07-08 at 15:21 -0400, Ilia Mirkin wrote:
> > > -/**
> > > +// SPDX-License-Identifier: MIT
> > > +/*
> > >   * \file drm_memory.c
> > >   * Memory management wrappers for DRM
> > >   *
> > > @@ -12,25 +13,6 @@
> > >   * Copyright 1999 Precision Insight, Inc., Cedar Park, Texas.
> > >   * Copyright 2000 VA Linux Systems, Inc., Sunnyvale, California.
> > >   * All Rights Reserved.
> > > - *
> > > - * Permission is hereby granted, free of charge, to any person obtaining a
> > > - * copy of this software and associated documentation files (the
> > > "Software"),
> > > - * to deal in the Software without restriction, including without
> > > limitation
> > > - * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> > > - * and/or sell copies of the Software, and to permit persons to whom the
> > > - * Software is furnished to do so, subject to the following conditions:
> > > - *
> > > - * The above copyright notice and this permission notice (including the
> > > next
> > > - * paragraph) shall be included in all copies or substantial portions of
> > > the
> > > - * Software.
> > > - *
> > > - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> > > OR
> > > - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> > > - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> > > - * VA LINUX SYSTEMS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, DAMAGES
> > > OR
> > 
> > This talks about VA Linux Systems and/or its suppliers, while the MIT
> > licence talks about authors or copyright holders.

That's looks lika a valid substitution and does not change the meaning of
the license, AFAICT. Richard might have a differnt opinion though.
 
> > Are such transformations OK to just do?

Nope.

> From,
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Document
> ation/process/license-rules.rst
> 
> "The Linux kernel requires the precise SPDX identifier in all source files."

That's correct.
 
> That is the closest license I can think of.

Well, it's pretty much plain MIT, but you might have noticed:

 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.

So in this case, you need to talk to the copyright holder if he agrees to
remove the boiler plate language.

Adding the MIT SPDX identifier without touching the boiler plate is fine.

Thanks,

	tglx