linux-kernel - Re: [PATCH] dma-mapping: mark dma_alloc_need_uncached as __always

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <63deb5f2-8fca-e519-1e0c-b63e765bfc6f@infradead.org>
Date:   Mon, 8 Jul 2019 14:14:27 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Christoph Hellwig <hch@....de>
Cc:     iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dma-mapping: mark dma_alloc_need_uncached as
 __always_inline

On 7/8/19 12:57 PM, Christoph Hellwig wrote:
> Without the __always_inline at least i386 configs that have
> CONFIG_OPTIMIZE_INLINING set seem fail to inline
> dma_alloc_need_uncached, leading to a linker error because of
> undefined symbols.
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Christoph Hellwig <hch@....de>

Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

Thanks.

> ---
>  include/linux/dma-noncoherent.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/dma-noncoherent.h b/include/linux/dma-noncoherent.h
> index 53ee36ecdf37..3813211a9aad 100644
> --- a/include/linux/dma-noncoherent.h
> +++ b/include/linux/dma-noncoherent.h
> @@ -23,7 +23,7 @@ static inline bool dev_is_dma_coherent(struct device *dev)
>  /*
>   * Check if an allocation needs to be marked uncached to be coherent.
>   */
> -static inline bool dma_alloc_need_uncached(struct device *dev,
> +static __always_inline bool dma_alloc_need_uncached(struct device *dev,
>  		unsigned long attrs)
>  {
>  	if (dev_is_dma_coherent(dev))
> 


-- 
~Randy