linux-kernel - bug report: re: vfs: Convert ceph to use the new mount API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2b919604-282e-85d6-b9d8-827beefdcb0d@canonical.com>
Date:   Mon, 8 Jul 2019 22:31:32 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     David Howells <dhowells@...hat.com>,
        "Yan, Zheng" <zyan@...hat.com>, Sage Weil <sage@...hat.com>,
        ceph-devel@...r.kernel.org, Al Viro <viro@...iv.linux.org.uk>,
        linux-block@...r.kernel.org,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: bug report: re: vfs: Convert ceph to use the new mount API

Hi,

Static analysis with Coverity on linux-next has detected an
uninitialized variable error in the following commit:

commit 108f95bfaa5665724159e66e4a26206b5589f126
Author: David Howells <dhowells@...hat.com>
Date:   Mon Mar 25 16:38:32 2019 +0000

    vfs: Convert ceph to use the new mount API


Specifically, in fs/ceph/super.c in function ceph_real_mount, variable
err is not initialized, and when the if (!fsc->sb->s_root) code block is
not executed then err is never assigned and an uninitialized value is
returned:

 884        mutex_unlock(&fsc->client->mount_mutex);

Uninitialized scalar variable (UNINIT)
uninit_use: Using uninitialized value err.

 885        return err;
 886
 887 out:
 888        mutex_unlock(&fsc->client->mount_mutex);
 889        return err;
 890 }

Not sure what err should be returning, so I'm reporting this a as bug.

Colin