linux-kernel - Re: [PATCH] gpio: davinci: silence error prints in case of EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 8 Jul 2019 14:36:48 +0200
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Keerthy <j-keerthy@...com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-gpio <linux-gpio@...r.kernel.org>,
        Tero Kristo <t-kristo@...com>
Subject: Re: [PATCH] gpio: davinci: silence error prints in case of EPROBE_DEFER

pon., 8 lip 2019 o 10:48 Keerthy <j-keerthy@...com> napisał(a):
>
> Silence error prints in case of EPROBE_DEFER. This avoids
> multiple/duplicate defer prints during boot.
>
> Signed-off-by: Keerthy <j-keerthy@...com>
> ---
>  drivers/gpio/gpio-davinci.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index fc494a84a29d..e0b025689625 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -238,8 +238,9 @@ static int davinci_gpio_probe(struct platform_device *pdev)
>         for (i = 0; i < nirq; i++) {
>                 chips->irqs[i] = platform_get_irq(pdev, i);
>                 if (chips->irqs[i] < 0) {
> -                       dev_info(dev, "IRQ not populated, err = %d\n",
> -                                chips->irqs[i]);
> +                       if (chips->irqs[i] != -EPROBE_DEFER)
> +                               dev_info(dev, "IRQ not populated, err = %d\n",
> +                                        chips->irqs[i]);
>                         return chips->irqs[i];
>                 }
>         }
> --
> 2.17.1
>

Applied to fixes, thanks.

Bart