linux-kernel - Re: [PATCH] mtd: remove c++ comments from uapi header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190708145426.62b4aabd@xps13>
Date:   Mon, 8 Jul 2019 14:54:26 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Marek Vasut <marek.vasut@...il.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        clang-built-linux@...glegroups.com
Subject: Re: [PATCH] mtd: remove c++ comments from uapi header

Hi Arnd,

Arnd Bergmann <arnd@...db.de> wrote on Mon,  8 Jul 2019 14:49:39 +0200:

> Checking the uapi headers now produces a warning with clang:
> 
> ./usr/include/mtd/mtd-abi.h:116:28: error: // comments are not allowed in this language [-Werror,-Wcomment]
> 
> Change these into standard C comments here.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  include/uapi/mtd/mtd-abi.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/include/uapi/mtd/mtd-abi.h b/include/uapi/mtd/mtd-abi.h
> index aff5b5e59845..47ffe3208c27 100644
> --- a/include/uapi/mtd/mtd-abi.h
> +++ b/include/uapi/mtd/mtd-abi.h
> @@ -113,11 +113,11 @@ struct mtd_write_req {
>  #define MTD_CAP_NVRAM		(MTD_WRITEABLE | MTD_BIT_WRITEABLE | MTD_NO_ERASE)
>  
>  /* Obsolete ECC byte placement modes (used with obsolete MEMGETOOBSEL) */
> -#define MTD_NANDECC_OFF		0	// Switch off ECC (Not recommended)
> -#define MTD_NANDECC_PLACE	1	// Use the given placement in the structure (YAFFS1 legacy mode)
> -#define MTD_NANDECC_AUTOPLACE	2	// Use the default placement scheme
> -#define MTD_NANDECC_PLACEONLY	3	// Use the given placement in the structure (Do not store ecc result on read)
> -#define MTD_NANDECC_AUTOPL_USR 	4	// Use the given autoplacement scheme rather than using the default
> +#define MTD_NANDECC_OFF		0	/* Switch off ECC (Not recommended) */
> +#define MTD_NANDECC_PLACE	1	/* Use the given placement in the structure (YAFFS1 legacy mode) */
> +#define MTD_NANDECC_AUTOPLACE	2	/* Use the default placement scheme */
> +#define MTD_NANDECC_PLACEONLY	3	/* Use the given placement in the structure (Do not store ecc result on read) */
> +#define MTD_NANDECC_AUTOPL_USR 	4	/* Use the given autoplacement scheme rather than using the default */
>  
>  /* OTP mode selection */
>  #define MTD_OTP_OFF		0

A similar patch has been sent a few weeks ago and has been applied
yesterday night so it should have appeared this morning in linux-next :)


Thanks anyway!
Miquèl