linux-kernel - [PATCH 4.14 53/56] MIPS: Fix bounds check virt_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190708150524.194818214@linuxfoundation.org>
Date:   Mon,  8 Jul 2019 17:13:45 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     linux-kernel@...r.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        stable@...r.kernel.org, Paul Burton <paul.burton@...s.com>,
        Hauke Mehrtens <hauke@...ke-m.de>, ralf@...ux-mips.org,
        jhogan@...nel.org, f4bug@...at.org, linux-mips@...r.kernel.org,
        ysu@...ecomp.com, jcristau@...ian.org
Subject: [PATCH 4.14 53/56] MIPS: Fix bounds check virt_addr_valid

From: Hauke Mehrtens <hauke@...ke-m.de>

commit d6ed083f5cc621e15c15b56c3b585fd524dbcb0f upstream.

The bounds check used the uninitialized variable vaddr, it should use
the given parameter kaddr instead. When using the uninitialized value
the compiler assumed it to be 0 and optimized this function to just
return 0 in all cases.

This should make the function check the range of the given address and
only do the page map check in case it is in the expected range of
virtual addresses.

Fixes: 074a1e1167af ("MIPS: Bounds check virt_addr_valid")
Cc: stable@...r.kernel.org # v4.12+
Cc: Paul Burton <paul.burton@...s.com>
Signed-off-by: Hauke Mehrtens <hauke@...ke-m.de>
Signed-off-by: Paul Burton <paul.burton@...s.com>
Cc: ralf@...ux-mips.org
Cc: jhogan@...nel.org
Cc: f4bug@...at.org
Cc: linux-mips@...r.kernel.org
Cc: ysu@...ecomp.com
Cc: jcristau@...ian.org
Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

---
 arch/mips/mm/mmap.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/mips/mm/mmap.c
+++ b/arch/mips/mm/mmap.c
@@ -203,7 +203,7 @@ unsigned long arch_randomize_brk(struct
 
 int __virt_addr_valid(const volatile void *kaddr)
 {
-	unsigned long vaddr = (unsigned long)vaddr;
+	unsigned long vaddr = (unsigned long)kaddr;
 
 	if ((vaddr < PAGE_OFFSET) || (vaddr >= MAP_BASE))
 		return 0;