linux-kernel - Re: sched/topology: One function call less in build_group_from_child_sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e3ae5bd2-d963-2422-d4f0-131a5d2edbb4@web.de>
Date:   Mon, 8 Jul 2019 17:44:13 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
        kernel-janitors@...r.kernel.org
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: sched/topology: One function call less in
 build_group_from_child_sched_domain()

> Yes, it definitely makes code readable.

Some developers seem to get difficulties with this view.


> I was only commenting on the changelog/subject which says
> avoids a function call which I think it doesn't.

Do you prefer an other wording for calling functions only once
with a selected parameter value instead of calling them (unoptimised)
within two branches of an if statement?

Regards,
Markus