linux-kernel - Re: [PATCH] drm/amdgpu: fix building without CONFIG_HMM_MIRROR

Open Source and information security mailing list archives

Date:   Mon, 8 Jul 2019 11:59:47 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        "David (ChunMing) Zhou" <David1.Zhou@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Philip Yang <Philip.Yang@....com>,
        Felix Kuehling <Felix.Kuehling@....com>,
        Michel Dänzer <michel.daenzer@....com>,
        LKML <linux-kernel@...r.kernel.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: fix building without CONFIG_HMM_MIRROR

On Mon, Jul 8, 2019 at 9:51 AM Arnd Bergmann <arnd@...db.de> wrote:
>
> 'struct hmm_mirror' is not defined without the Kconfig option set,
> so we cannot include it within another struct:
>
> In file included from drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgpu.h:72:
> drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgpu_mn.h:69:20: error: field has incomplete type 'struct hmm_mirror'
>         struct hmm_mirror       mirror;
>                                 ^
> drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgpu_mn.h:69:9: note: forward declaration of 'struct hmm_mirror'
>         struct hmm_mirror       mirror;
>
> Add the #ifdef around it that is also used for all functions operating
> on it.
>
> Fixes: 7590f6d211ec ("drm/amdgpu: Prepare for hmm_range_register API change")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.  thanks!

Alex

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_mn.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.h
> index 281fd9fef662..b8ed68943625 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.h
> @@ -65,8 +65,10 @@ struct amdgpu_mn {
>         struct rw_semaphore     lock;
>         struct rb_root_cached   objects;
>
> +#ifdef CONFIG_HMM_MIRROR
>         /* HMM mirror */
>         struct hmm_mirror       mirror;
> +#endif
>  };
>
>  #if defined(CONFIG_HMM_MIRROR)
> --
> 2.20.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives