linux-kernel - Re: [PATCH v4 1/2] dt-bindings: interrupt-controller: Amazon's Annapurna Labs FIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1fd393d-0b8c-16f1-9ac2-0589e9cb9ea7@amazon.com>
Date:   Tue, 9 Jul 2019 08:59:40 +0300
From:   "Shenhar, Talel" <talel@...zon.com>
To:     Rob Herring <robh@...nel.org>
CC:     <nicolas.ferre@...rochip.com>, <jason@...edaemon.net>,
        <marc.zyngier@....com>, <mark.rutland@....com>,
        <mchehab+samsung@...nel.org>, <davem@...emloft.net>,
        <shawn.lin@...k-chips.com>, <tglx@...utronix.de>,
        <devicetree@...r.kernel.org>, <gregkh@...uxfoundation.org>,
        <linux-kernel@...r.kernel.org>, <dwmw@...zon.co.uk>,
        <benh@...nel.crashing.org>, <jonnyc@...zon.com>,
        <hhhawa@...zon.com>, <ronenk@...zon.com>, <hanochu@...zon.com>,
        <barakw@...zon.com>
Subject: Re: [PATCH v4 1/2] dt-bindings: interrupt-controller: Amazon's
 Annapurna Labs FIC

Marc, should I publish those fixes as new patch that updates the 
dt-bindings or new patchset to this list?

On 7/9/2019 5:23 AM, Rob Herring wrote:
> On Mon, Jun 10, 2019 at 11:34:42AM +0300, Talel Shenhar wrote:
>> +- #interrupt-cells: must be 2.
>> +  First cell defines the index of the interrupt within the controller.
>> +  Second cell is used to specify the trigger type and must be one of the
>> +  following:
>> +    - bits[3:0] trigger type and level flags
>> +	1 = low-to-high edge triggered
>> +	4 = active high level-sensitive
> No need to define this here. Reference the standard definition.

This device only support those two modes.

This definition tries to capture the supported modes.

Should I just state that those two modes are supported and then avoid 
the actual bits and values?

>
>> +- interrupt-parent: specifies the parent interrupt controller.
> Drop this. It is implied and could be in the parent.
ack
>
>> +- interrupts: describes which input line in the interrupt parent, this
>> +  fic's output is connected to. This field property depends on the parent's
>> +  binding
>> +
>> +Example:
>> +
>> +amazon_fic: interrupt-controller@...d8a8500 {
> Drop the '0x'
ack