linux-kernel - Re: [PATCH] habanalabs: use %pad for printing a dma_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 9 Jul 2019 09:07:37 +0300
From:   Oded Gabbay <oded.gabbay@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Tomer Tayar <ttayar@...ana.ai>,
        Mike Rapoport <rppt@...ux.ibm.com>,
        Omer Shpigelman <oshpigelman@...ana.ai>,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] habanalabs: use %pad for printing a dma_addr_t

On Mon, Jul 8, 2019 at 3:39 PM Arnd Bergmann <arnd@...db.de> wrote:
>
> dma_addr_t might be different sizes depending on the configuration,
> so we cannot print it as %llx:
>
> drivers/misc/habanalabs/goya/goya.c: In function 'goya_sw_init':
> drivers/misc/habanalabs/goya/goya.c:698:21: error: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'dma_addr_t' {aka 'unsigned int'} [-Werror=format=]
>
> Use the special %pad format string. This requires passing the
> argument by reference.
>
> Fixes: 2a51558c8c7f ("habanalabs: remove DMA mask hack for Goya")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/misc/habanalabs/goya/goya.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/goya/goya.c
> index 75294ec65257..60e509f64051 100644
> --- a/drivers/misc/habanalabs/goya/goya.c
> +++ b/drivers/misc/habanalabs/goya/goya.c
> @@ -695,8 +695,8 @@ static int goya_sw_init(struct hl_device *hdev)
>                 goto free_dma_pool;
>         }
>
> -       dev_dbg(hdev->dev, "cpu accessible memory at bus address 0x%llx\n",
> -               hdev->cpu_accessible_dma_address);
> +       dev_dbg(hdev->dev, "cpu accessible memory at bus address %pad\n",
> +               &hdev->cpu_accessible_dma_address);
>
>         hdev->cpu_accessible_dma_pool = gen_pool_create(ilog2(32), -1);
>         if (!hdev->cpu_accessible_dma_pool) {
> --
> 2.20.0
>

This patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@...il.com>

Thanks! applied to -next