linux-kernel - Re: [PATCHv2 4/4] tty: n_gsm: add ioctl to map serial device to mux'ed tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <764ab112-0e0d-fa10-607a-6ffb1f53297d@geanix.com>
Date:   Tue, 9 Jul 2019 08:52:22 +0200
From:   Martin Hundebøll <martin@...nix.com>
To:     Jiri Slaby <jslaby@...e.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Cc:     Esben Haabendal <esben@...nix.com>,
        Sean Nyekjær <sean@...nix.com>
Subject: Re: [PATCHv2 4/4] tty: n_gsm: add ioctl to map serial device to
 mux'ed tty

On 09/07/2019 08.49, Jiri Slaby wrote:
> On 09. 07. 19, 8:46, Martin Hundebøll  wrote:
>> @@ -2623,6 +2624,9 @@ static int gsmld_ioctl(struct tty_struct *tty, struct file *file,
>>   		if (copy_from_user(&c, (void *)arg, sizeof(c)))
>>   			return -EFAULT;
>>   		return gsm_config(gsm, &c);
>> +	case GSMIOC_GETBASE:
>> +		base = mux_num_to_base(gsm);
>> +		return put_user(base, (int __user *)arg);
> I am not sure, but do you need the local variable at all?

No, I kept it around just to avoid too many parenthesis in the 
put_user() call.

Your call.

// Martin