linux-kernel - Re: [PATCH v4 1/1] power: supply: Add HWMON compatibility layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 9 Jul 2019 00:27:40 -0700
From:   Andrey Smirnov <andrew.smirnov@...il.com>
To:     Sebastian Reichel <sre@...nel.org>
Cc:     Linux PM list <linux-pm@...r.kernel.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Chris Healy <cphealy@...il.com>,
        Cory Tusar <cory.tusar@....aero>,
        Lucas Stach <l.stach@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/1] power: supply: Add HWMON compatibility layer

On Thu, Jun 27, 2019 at 11:27 AM Sebastian Reichel <sre@...nel.org> wrote:
>
> Hi,
>
> On Wed, Jun 12, 2019 at 01:44:04AM -0700, Andrey Smirnov wrote:
> > Add code implementing HWMON adapter/compatibility layer to allow
> > expositing various sensors present on power supply devices via HWMON
> > subsystem. This is done in order to allow userspace to use single
> > ABI/library(libsensors) to access/manipulate all of the sensors of the
> > system.
> >
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
> > Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> > Tested-by: Chris Healy <cphealy@...il.com>
> > ---
>
> Thanks, queued.
>

Hmm, I just realized that power supply exposing POWER_SUPPLY_PROP_TEMP
will have a thermal zone created for it by default, which will expose
said reading via thermal/HWMON integration layer. Do we want to do
anything about this duplication of functionality? Maybe hide it here
if desc->no_thermal is true? Or just drop reporting temperature from
this patch?

Thanks,
Andrey Smirnov