linux-kernel - Re: [PATCH] drm/client: remove the exporting of drm_client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9590074a-dbc4-24d3-4f93-51d942981860@tronnes.org>
Date:   Tue, 9 Jul 2019 11:42:54 +0200
From:   Noralf Trønnes <noralf@...nnes.org>
To:     Emil Velikov <emil.l.velikov@...il.com>,
        Denis Efremov <efremov@...ux.com>
Cc:     ML dri-devel <dri-devel@...ts.freedesktop.org>,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/client: remove the exporting of drm_client_close



Den 04.07.2019 16.07, skrev Emil Velikov:
> On Thu, 4 Jul 2019 at 08:27, Denis Efremov <efremov@...ux.com> wrote:
>>
>> The function drm_client_close is declared as static and marked as
>> EXPORT_SYMBOL. It's a bit confusing for an internal function to be
>> exported. The area of visibility for such function is its .c file
>> and all other modules. Other *.c files of the same module can't use it,
>> despite all other modules can. Relying on the fact that this is the
>> internal function and it's not a crucial part of the API, the patch
>> removes the EXPORT_SYMBOL marking of drm_client_close.
>>
>> Signed-off-by: Denis Efremov <efremov@...ux.com>
> 
> Nice one:
> Reviewed-by: Emil Velikov <emil.velikov@...labora.com>

Thanks, applied.

Noralf.